search

LSSTDESC / descwl-coadd-task

DM Task to run coaddition in cells
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Add band as a dimension #1

Closed arunkannawadi closed 3 years ago

arunkannawadi commented 3 years ago

I haven't test this yet. I'm yet to setup the descwl_coadd repo

esheldon commented 3 years ago

Thanks Arun.

Why is it called band in some places and bands (plural) in others? And why is band a list?

esheldon commented 3 years ago

To be clear: the idea was that this code would not process a single band

esheldon commented 3 years ago

sorry I meant to write "would now process a single band"

arunkannawadi commented 3 years ago

Thanks for the clarification, Erin. I misunderstood your ask to mean that we want to be able to make a single band coadd for quick testing purposes and turn on multiband coadd eventually. I'm making it a single-band coadd only now.

arunkannawadi commented 3 years ago

There is a call to MultiBandCoaddsDM. Should that stay as it is?

esheldon commented 3 years ago

That is an old version of the coadd code.

For testing you might want to comment that stuff out for now. I can put in the correct calls later.

esheldon commented 3 years ago

(or you can checkout an older version)

arunkannawadi commented 3 years ago

The middleware will setup parallel runs (different 'quanta') if multiple bands (or no bands) are specified at the command line. The code for this task can safely assume there is only one band specified.

On Fri, Aug 27, 2021, 11:09 AM Matthew R. Becker @.***> wrote:

@.**** commented on this pull request.

In run.sh https://github.com/LSSTDESC/descwl-coadd-task/pull/1#discussion_r697517976 :

@@ -2,7 +2,8 @@

Gen3

-export REPO=/project/hsc/gen3repo/rc2v21_0_0_rc1_ssw48 -setup -j -r . -pipetask run -t lsstdesc.pipe.task.coadd_in_cells.CoaddInCellsTask -b $REPO --input HSC/runs/RC2/v21_0_0_rc1 --output u/$USER/coaddTest -d "skymap='hsc_rings_v1' AND tract=9615 AND patch=45" --register-dataset-types -butler query-datasets $REPO --collections u/$USER/* coaddObj +export REPO=/repo/main +export INPUT_COLLECTION=HSC/runs/RC2/w_2021_30/DM-31182 +setup -k -r . +pipetask run -t lsstdesc.descwl.coadd.coadd_in_cells.CoaddInCellsTask -b $REPO --input $INPUT_COLLECTION --output u/$USER/coaddTest -d "skymap='hsc_rings_v1' AND tract=9615 AND patch=45 AND band='r'" --register-dataset-types

I 100% agree w/ Erin. There are higher-level workflow tools within DM to coordinate running this more than once. The loop over bands needs to happen there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/descwl-coadd-task/pull/1#discussion_r697517976, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG56HVPV6FUYLZMV7QK56TT66TD7ANCNFSM5BFV2FIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

esheldon commented 3 years ago

Then I think it should be a required argument and we should assert the length is one

esheldon commented 3 years ago

looks good to me