search

LSSTDESC / descwl-coadd-task

DM Task to run coaddition in cells
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Add a concrete coaddition implementation for cell-based coadds #3

Closed arunkannawadi closed 8 months ago

arunkannawadi commented 2 years ago

This PR should be merged and should be good to go after DM-32412 in Rubin Science Pipelines is complete. If you'd like to run it at NCSA before that, ensure that daf_butler and cell_coadds are checkout out to tickets/DM-32412 branch.

More instructions on running it with bps batch submission and example notebooks to explore the images are coming up next.

arunkannawadi commented 2 years ago

The other code changes requested are addressed now.

esheldon commented 8 months ago

Arun are you still waiting until other codes are ready, or is this ready for a full review?

arunkannawadi commented 8 months ago

This is ready for review by itself.

esheldon commented 8 months ago

What changed? Was there updates in other codes that made this one ready now but it wasn't ready two months ago at the last push?

arunkannawadi commented 8 months ago

It was ready for review months ago, particularly the code in _warp_task.py and _coadd_task.py.

esheldon commented 8 months ago

I got a review request in July, but not since the recent changes. I had made a few comments, but I thought this was still WIP

esheldon commented 8 months ago

Actually the original review request was July 2022, no requests since then