LSSTDESC / descwl-shear-sims

simple simulations for testing weak lensing shear measurement
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

Distort wcs #100

Closed esheldon closed 4 years ago

esheldon commented 4 years ago

closes #48

TODO

esheldon commented 4 years ago

the galsim wcs had the ability to write out the fits hdr keywords to a dict, so we don't need to pass along the header

esheldon commented 4 years ago

Use the wcs._writeHeader method.

beckermr commented 4 years ago

We might want to ask @rmjarvis if we can convert this to a public API so it doesn't change on us.

esheldon commented 4 years ago

There is a public one writeToFitsHeader but it takes a bounds instance that is not needed

beckermr commented 4 years ago

A writeToDict method might be useful generally and fit the bill.

esheldon commented 4 years ago

looking at the code, I guess I could fake it with galsim.BoundsI(1, anything, 1, anything) since it only checks that the xmin and xmax are 1

esheldon commented 4 years ago

that code will go into descwl_coadd, so I'm ready to merge this one if you are matt

esheldon commented 4 years ago

I ran tests locally, true they aren't running in travis since we don't have the catsim data

beckermr commented 4 years ago

But the tan-sip doesn't use catsim, so why have the decorators there at all?

esheldon commented 4 years ago

It reads data from CATSIM_DIR