search

LSSTDESC / descwl-shear-sims

simple simulations for testing weak lensing shear measurement
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

consider speeding up the shear tests #164

Closed esheldon closed 2 years ago

esheldon commented 2 years ago

These take hour(s)

beckermr commented 2 years ago

There is a fast one and a slow one. You should only be running the fast one locally. See here:

https://github.com/LSSTDESC/descwl-shear-sims/blob/d1e11e9d537980eae6512a3ed9a0d0e0f3e3a605/shear_meas_tests/test_shear_meas.py#L162

something like pytest -k test_shear_meas[500-grid] should work.

beckermr commented 2 years ago

We should turn them off for PRs maybe.

removing this key will do that: https://github.com/LSSTDESC/descwl-shear-sims/blob/master/.github/workflows/shear_meas_tests.yml#L7

esheldon commented 2 years ago

The fast one takes an hour in CI

esheldon commented 2 years ago

Is this a sign of a performance regression?

esheldon commented 2 years ago

Does that "push" mean that it always runs on any push?

Then turning this off makes it not run for the PR but would on the push to a branch?

beckermr commented 2 years ago

Performance looks fine. The fast one is maybe 10 minutes slower than it used to be, but typically takes 25-35 minutes.

The "push" means a push to any of the branches listed. So it would still run on pushes to master.