search

LSSTDESC / descwl-shear-sims

simple simulations for testing weak lensing shear measurement
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

Maintenance update after recent changes in lsst.afw.image.exposure._exposure.ExposureF #190

Closed EiffL closed 1 year ago

EiffL commented 1 year ago

From a clean/fresh install of the conda environment recommended for this package, I'm getting an error at this line: https://github.com/LSSTDESC/descwl-shear-sims/blob/0b1844428f673f169be4e9e76f2fef08e6ab7df4/descwl_shear_sims/sim.py#L433

And digging through the afw code, it looks like that method has been removed by Eli back in October: https://github.com/lsst/afw/commit/ae33f7b6e9a0437c374e81655991ba9bdfd3feb8

This PR simply proposes to use the .setFilter method instead

beckermr commented 1 year ago

Looks like that doesn't work. Maybe @erykoff can help here?

beckermr commented 1 year ago

If you check the mdet paper draft, you can install the older version of the stack we used there and things will run.

EiffL commented 1 year ago

Hummmm ok yeah, it works on my machine with the new version of the stack, I guess it's a question of which version is to be used as a reference.

beckermr commented 1 year ago

Which version on your machine works?

EiffL commented 1 year ago 
stack_data                0.6.2              pyhd8ed1ab_0    conda-forge
stackvana                 0.2023.6        py310hff52083_0    conda-forge
stackvana-afw             0.2023.6        py310hff52083_0    conda-forge
stackvana-core            0.2023.6        py310hff52083_0    conda-forge
stackvana-core-impl       0.2023.6        py310hff52083_0    conda-forge
stackvana-lsst_distrib    0.2023.6        py310h58b28c2_0    conda-forge

Are these the relevant bits?

beckermr commented 1 year ago

yep I know the issue now. sit tight.

erykoff commented 1 year ago

You don't need me then?

beckermr commented 1 year ago

We'll see @erykoff...