search

LSSTDESC / descwl-shear-sims

simple simulations for testing weak lensing shear measurement
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

add support for hex and grid layout for DeblendedGalaxy #191

Closed mr-superonion closed 8 months ago

mr-superonion commented 1 year ago

see issue https://github.com/LSSTDESC/descwl-shear-sims/issues/152

The galaxy number density is determined by the layout for these two cases.

mr-superonion commented 1 year ago 
/usr/share/miniconda/envs/test/lib/python3.10/site-packages/hexalattice/hexalattice.py:17: in <module>
    matplotlib.use('Qt5Agg')

The test does not pass. But this is the problem of hexalattice.

mr-superonion commented 1 year ago

It is this commit: https://github.com/alexkaz2/hexalattice/commit/14bb67cf939c29b9d57e6b11815beea3a46e0218

I report an issue: https://github.com/alexkaz2/hexalattice/issues/10

esheldon commented 1 year ago

Yeah, that's a bug in hexalattice, it shouldn't require that

mr-superonion commented 1 year ago

@esheldon , I think the bug is fixed after the issue in hexalattice is fixed! Could you please review the PR?

mr-superonion commented 1 year ago

@esheldon , similar problem in stack, I think the problem comes with 0.2023.29. For 0.2023.28, I did not see the error in the pytests.

mr-superonion commented 8 months ago

@esheldon , @beckermr , I think this PR is ready to merge!

mr-superonion commented 8 months ago

shall we merge? @esheldon , @beckermr