Add Shear Object enabling Redshift-dependent Shear

LSSTDESC / descwl-shear-sims

simple simulations for testing weak lensing shear measurement

BSD 3-Clause "New" or "Revised" License

10 stars 9 forks source link

Add Shear Object enabling Redshift-dependent Shear #200

Closed mr-superonion closed 9 months ago

mr-superonion commented 10 months ago

@ismael-mendoza and I made this pull request for the redshift dependent shear simulation.

This file contains the shear objects that is used to generate shear for different tests.
Unit test for this implementation can be found here.

mr-superonion commented 10 months ago

@esheldon , @beckermr, Could you please review when you are free?

esheldon commented 10 months ago

One general comment: I would like to keep shear-measurement specific code out of this repo, for example the new code you added bin/simulate_image.py

esheldon commented 9 months ago

The code needs to pass flake8.

mr-superonion commented 9 months ago

Hello @esheldon , I checked that the latest stackvana=0.2023.47 works. The newer version of mamba (mamba>1.5.1) seems to have some problems (see here). Therefore, I set mamba==1.5.1 in the github workflow (see here).

I think this PR is ready to merge.

esheldon commented 9 months ago

Thanks for the PR