search

LSSTDESC / descwl-shear-sims

simple simulations for testing weak lensing shear measurement
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

Return "truth catalog" info #208

Closed zhouconghao closed 2 months ago

zhouconghao commented 2 months ago

make_exp returns ra, dec, and redshift of simulated objects. As mentioned in this issue.

zhouconghao commented 2 months ago

Sorry incidentally also include another PR in this. I can try to revert it if needed.

esheldon commented 2 months ago

The change of se_wcs to a dict is a breaking change. I do think it should have its own PR

zhouconghao commented 2 months ago

The change of se_wcs to a dict is a breaking change. I do think it should have its own PR

Thanks @esheldon ! I have already submitted a PR on returning se_wcs here. Maybe this PR can be merged first to avoid rebasing? Happy to modify the code too as it's not too much.

zhouconghao commented 2 months ago

This looks good to me.

In the future when submitting PRs please do not run "black". It makes a large number of unnecessary changes.

Got it! Thanks!