search

LSSTDESC / descwl_coadd

Tools for coadding using the LSST DM software stack
GNU General Public License v3.0
2 stars 2 forks source link

Log individual flag in verify_warp #85

Closed zhouconghao closed 1 month ago

zhouconghao commented 1 month ago

Currently, verify_warp always logs the first flag name with the total number of flagged pixels, which might be confusing if there are more than one flag. After this PR the code should correctly log the right flag name and right number of flagged pixels joined by and.

Should I write a test for this, given it's a bug in the log message? Thanks!

zhouconghao commented 1 month ago

The failing test is being addressed in https://github.com/LSSTDESC/descwl_coadd/pull/86

esheldon commented 1 month ago

Rather than using print should we add these to the exception string?

zhouconghao commented 1 month ago

Thank you, Erin! The size and flag name info is already in the exception string so I just deleted print.

esheldon commented 1 month ago

looks good to me