LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Number count statistic #204

Closed vitenti closed 1 year ago

vitenti commented 1 year ago

To make it easier for us to review your PR, please consult https://firecrown.readthedocs.io/en/latest/developer_installation.html#before-committing-code to see the set of tests and verifications that the CI system will run when a pull request is created.

Thanks.

eduardojsbarroso commented 1 year ago

In this pull request, I implemented the following features:

eduardojsbarroso commented 1 year ago

The code is ready. I used mock data to test it and I think everything is fine. I just need help with the question on slack and then decide how flexible the code should be.

The delta for oversensitivity should be fixed? The mass integral for the richness proxy should have arbitrary intervals decided by the user?

I will wait for your input @vitenti @marcpaterno. Thank you

eduardojsbarroso commented 1 year ago

@vitenti Check only cluster_abundance, cluster_redshift and cluster_mass. Once we decide on the cluster_abundance object, I'm going to apply the same changes to cluster_mean_mass.