Closed vitenti closed 1 year ago
In this pull request, I implemented the following features:
firecrown\likelihood\gauss_family\statistics\cluster_number_counts.py
-> The statisics to compute the theory and the data vector from a given SACC file.firecrown\likelihood\gauss_family\statistics\cluster_number_counts_enum.py
-> Enum
classes with the supported types of tracers, data types and proxy types.firecrown\models\
-> New folder with the number_density
abstract class, which is inheritaed by CCLDensity
to implement the supported halo mass functions. The CCLDensity
object computes the number density and the volume. It is used in cluster_number_counts.py
.firecrown\models\richness_proxy
-> Mass proxy used in cluster_number_counts.py
when the tracer type is the richness_proxy
. It has the mass-proxy relation for richness.firecrown\examples\number_counts
The code is ready. I used mock data to test it and I think everything is fine. I just need help with the question on slack and then decide how flexible the code should be.
The delta for oversensitivity should be fixed? The mass integral for the richness proxy should have arbitrary intervals decided by the user?
I will wait for your input @vitenti @marcpaterno. Thank you
@vitenti Check only cluster_abundance
, cluster_redshift
and cluster_mass
. Once we decide on the cluster_abundance object, I'm going to apply the same changes to cluster_mean_mass
.
To make it easier for us to review your PR, please consult https://firecrown.readthedocs.io/en/latest/developer_installation.html#before-committing-code to see the set of tests and verifications that the CI system will run when a pull request is created.
Thanks.