LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Prepare classes in sacc_support.py for move to SACC #280

Closed marcpaterno closed 1 year ago

marcpaterno commented 1 year ago

After some design review, we want to make two tweaks to the tracer classes in sacc_support.py before moving them to SACC.

  1. The instance variable names should be changed to support generic programming (“duck typing”): the various x_upper and x_lower should become upper and lower; we can rely on the type of the object to know that BinZTracer.lower refers to a value of z. This allows functions to manipulate different kinds of bins when that is appropriate
  2. The center variable in any bin should be documented as the location to use for a single point estimate, since it not required to be the arithmetic or geometric mean of the bin. Rather, it is the value that should be used if only one value is wanted for a point estimate of the location of that bin.