LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

375 python 39+ no longer needs typinglist set dict or tuple #376

Closed marcpaterno closed 7 months ago

marcpaterno commented 7 months ago

This will close issue #375

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (be43590) 96.3% compared to head (0c070cf) 96.3%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ======================================== - Coverage 96.3% 96.3% -0.1% ======================================== Files 35 35 Lines 2568 2564 -4 ======================================== - Hits 2474 2470 -4 Misses 94 94 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [firecrown/connector/cobaya/ccl.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2Nvbm5lY3Rvci9jb2JheWEvY2NsLnB5) | `100.0% <100.0%> (ø)` | | | [firecrown/connector/cobaya/likelihood.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2Nvbm5lY3Rvci9jb2JheWEvbGlrZWxpaG9vZC5weQ==) | `100.0% <100.0%> (ø)` | | | [firecrown/connector/mapping.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2Nvbm5lY3Rvci9tYXBwaW5nLnB5) | `100.0% <100.0%> (ø)` | | | [firecrown/connector/numcosmo/numcosmo.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2Nvbm5lY3Rvci9udW1jb3Ntby9udW1jb3Ntby5weQ==) | `99.7% <100.0%> (ø)` | | | [firecrown/likelihood/gauss\_family/gauss\_family.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L2dhdXNzX2ZhbWlseS5weQ==) | `98.7% <100.0%> (ø)` | | | [...s\_family/statistic/binned\_cluster\_number\_counts.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L3N0YXRpc3RpYy9iaW5uZWRfY2x1c3Rlcl9udW1iZXJfY291bnRzLnB5) | `98.5% <100.0%> (ø)` | | | [...ood/gauss\_family/statistic/source/number\_counts.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L3N0YXRpc3RpYy9zb3VyY2UvbnVtYmVyX2NvdW50cy5weQ==) | `83.4% <100.0%> (ø)` | | | [...likelihood/gauss\_family/statistic/source/source.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L3N0YXRpc3RpYy9zb3VyY2Uvc291cmNlLnB5) | `100.0% <100.0%> (ø)` | | | [...hood/gauss\_family/statistic/source/weak\_lensing.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L3N0YXRpc3RpYy9zb3VyY2Uvd2Vha19sZW5zaW5nLnB5) | `100.0% <100.0%> (ø)` | | | [...own/likelihood/gauss\_family/statistic/statistic.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L3N0YXRpc3RpYy9zdGF0aXN0aWMucHk=) | `91.1% <100.0%> (ø)` | | | ... and [14 more](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/376?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | |
mattkwiecien commented 7 months ago

Now that we have codecov checks working ( #381 ) and coveralls is failing here, we may want to merge #381 first. That way we could see coveralls fail and codecov succeed for this edge case of removing code decreasing total coverage.