search

LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Remove Validator base class, fix hidden type error #378

Closed marcpaterno closed 7 months ago

marcpaterno commented 7 months ago

This will close issue #377 . It also fixes a type error that was made manifest when the tighter type signatures were put into place.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (481a6bc) 96.2% compared to head (8cee81e) 96.2%. Report is 1 commits behind head on master.

:exclamation: Current head 8cee81e differs from pull request most recent head 8070355. Consider uploading reports for the commit 8070355 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #378 +/- ## ====================================== Coverage 96.2% 96.2% ====================================== Files 35 35 Lines 2569 2573 +4 ====================================== + Hits 2472 2476 +4 Misses 97 97 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [firecrown/connector/mapping.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2Nvbm5lY3Rvci9tYXBwaW5nLnB5) | `100.0% <100.0%> (ø)` | | | [firecrown/descriptors.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2Rlc2NyaXB0b3JzLnB5) | `100.0% <100.0%> (ø)` | |