search

LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Re-adding codecov status checks to PRs. #381

Closed mattkwiecien closed 7 months ago

mattkwiecien commented 7 months ago

Fix

Removing the branches option from our codecov.yml configuration to re-enable status checks on PRs.

For future reference:

After speaking with support, this option specifies which source branches will trigger status checks, not target branches.

For example, I assumed branches: [master] meant, “A PR from any branch into master will trigger codecov status checks”. However it really means “A PR from master into any other branch will trigger status checks”.

While I find this option sort of strange, since conventionally one wouldnt PR from master into any other branch, removing the branches config value from my patch and project sections completely fixed the issue.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (449511b) 96.2% compared to head (94104cc) 96.2%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #381 +/- ## ====================================== Coverage 96.2% 96.2% ====================================== Files 35 35 Lines 2569 2569 ====================================== Hits 2472 2472 Misses 97 97 ```