search

LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

395 reduce complexity measure in twopoint class #396

Closed marcpaterno closed 6 months ago

marcpaterno commented 6 months ago

This will close issue #395

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 84.93151% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 95.6%. Comparing base (73af686) to head (d698ef1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #396 +/- ## ====================================== Coverage 95.5% 95.6% ====================================== Files 35 35 Lines 2583 2621 +38 ====================================== + Hits 2469 2506 +37 - Misses 114 115 +1 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [firecrown/parameters.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL3BhcmFtZXRlcnMucHk=) | `96.0% <100.0%> (-0.1%)` | :arrow_down: | | [...own/likelihood/gauss\_family/statistic/two\_point.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NfZmFtaWx5L3N0YXRpc3RpYy90d29fcG9pbnQucHk=) | `76.1% <84.7%> (+5.2%)` | :arrow_up: |
mattkwiecien commented 6 months ago

We are bypassing the codecov 100% patch status check for a few reasons:

  1. two_point.py has an impending redesign
  2. The coverage has increased overall
  3. This contains a bug fix relating to window functions and $\xi(\theta)$