TwoPoint.calculate_pk fails if first source has, and second source lacks, a PT systematic

LSSTDESC / firecrown

DESC Cosmology Likelihood Framework

BSD 3-Clause "New" or "Revised" License

29 stars 7 forks source link

TwoPoint.calculate_pk fails if first source has, and second source lacks, a PT systematic #413

Closed marcpaterno closed 3 months ago

marcpaterno commented 4 months ago

The code in TwoPoint.calcuate_pk does not handle the two tracers it is given symmetrically; if the first is associated with a source that has a PT systematic, and the second is associated with a source that lacks a PT systematic, it will fail.

marcpaterno commented 4 months ago

We should have a test that demonstrates this bug.

marcpaterno commented 4 months ago

Reopening the issue to fix the problem on the two_point_refactor branch, which is our (unfortunate) branch name for the branch we are using for bug fixes to the v1.7 version of Firecrown.

marcpaterno commented 4 months ago

Now I'm actually going to re-open the issue. If I click on the right button.

marcpaterno commented 3 months ago

This is fixed on master PR #418, and on the branch for the v1.7.x releases (two_point_refactor, for historical reasonas) by PR #415.