search

LSSTDESC / firecrown

DESC Cosmology Likelihood Framework
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Restructuring metadata objects #448

Closed vitenti closed 1 month ago

vitenti commented 2 months ago

This PR restructures and refactors the metadata objects for clarity and better organization of the codebase. The key changes are as follows:

  1. Renaming:

    • TwoPointXiTheta has been renamed to TwoPointReal to provide a more intuitive and accurate representation of its functionality.

  2. Merging:

    • The classes TwoPointCell and TwoPointCWindow have been merged into a single class named TwoPointHarmonic, simplifying the structure and avoiding redundancy.

  3. Reversing Metadata and Data Relationship:

    • Previously, data was an optional attribute within the metadata classes. This has now been reversed: new data dataclasses have been introduced that will encapsulate the metadata dataclasses. This change improves the separation of concerns and ensures better data organization and handling across the system.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.4%. Comparing base (5b28284) to head (bd722d0). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #448 +/- ## ======================================== - Coverage 98.4% 98.4% -0.1% ======================================== Files 48 50 +2 Lines 3666 3656 -10 ======================================== - Hits 3611 3601 -10 Misses 55 55 ``` | [Files with missing lines](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [firecrown/data\_functions.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Fdata_functions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2RhdGFfZnVuY3Rpb25zLnB5) | `100.0% <100.0%> (ø)` | | | [firecrown/data\_types.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Fdata_types.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2RhdGFfdHlwZXMucHk=) | `100.0% <100.0%> (ø)` | | | [firecrown/generators/inferred\_galaxy\_zdist.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Fgenerators%2Finferred_galaxy_zdist.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2dlbmVyYXRvcnMvaW5mZXJyZWRfZ2FsYXh5X3pkaXN0LnB5) | `100.0% <100.0%> (ø)` | | | [firecrown/likelihood/gaussfamily.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Flikelihood%2Fgaussfamily.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvZ2F1c3NmYW1pbHkucHk=) | `99.4% <100.0%> (ø)` | | | [firecrown/likelihood/number\_counts.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Flikelihood%2Fnumber_counts.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvbnVtYmVyX2NvdW50cy5weQ==) | `91.1% <100.0%> (ø)` | | | [firecrown/likelihood/two\_point.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Flikelihood%2Ftwo_point.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2QvdHdvX3BvaW50LnB5) | `98.2% <100.0%> (-0.1%)` | :arrow_down: | | [firecrown/likelihood/weak\_lensing.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Flikelihood%2Fweak_lensing.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL2xpa2VsaWhvb2Qvd2Vha19sZW5zaW5nLnB5) | `96.2% <100.0%> (ø)` | | | [firecrown/metadata\_functions.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Fmetadata_functions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL21ldGFkYXRhX2Z1bmN0aW9ucy5weQ==) | `100.0% <100.0%> (ø)` | | | [firecrown/metadata\_types.py](https://app.codecov.io/gh/LSSTDESC/firecrown/pull/448?src=pr&el=tree&filepath=firecrown%2Fmetadata_types.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-ZmlyZWNyb3duL21ldGFkYXRhX3R5cGVzLnB5) | `100.0% <100.0%> (ø)` | |