search

LSSTDESC / gcr-catalogs

A Python module that provides a unified interface to access mock galaxy catalogs and more for the LSST DESC
https://github.com/LSSTDESC/gcr-catalogs
BSD 3-Clause "New" or "Revised" License
26 stars 20 forks source link

Expose galaxy ellipticity in protoDC2 reader #15

Closed EiffL closed 6 years ago

EiffL commented 7 years ago

The current implementation of the reader does not define an ellipticity field for the galaxy, nor does it define fields like disk_re_a_true related to galaxy morphology. The information seems to be in there (a number of morphology related native fields) but not sure how they translate into the quantities described in the schema.

yymao commented 7 years ago

Does anyone know why/how GitHub prevents me from assigning @dkorytov ..?

BTW, @j-dr, how was ellipticity defined in the Buzzard catalog?

j-dr commented 7 years ago

Ellipticity (shear) is defined as being the components of ellipticity (shear) along the local RA,DEC directions.

yymao commented 7 years ago

Note: this is required by https://github.com/LSSTDESC/descqa/issues/14

dkorytov commented 7 years ago

I'll add the ellipticity along RA/Dec and expose them as GCR quantities.

On Wed, Nov 15, 2017 at 8:31 PM, Yao-Yuan Mao notifications@github.com wrote:

Note: this is required by LSSTDESC/descqa#14 https://github.com/LSSTDESC/descqa/issues/14

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LSSTDESC/gcr-catalogs/issues/15#issuecomment-344796253, or mute the thread https://github.com/notifications/unsubscribe-auth/AX4z_ebvp56WfXoxxbGxYghaQ3GmP00hks5s255-gaJpZM4QT2UI .

yymao commented 6 years ago

This has been fixed already.