search

LSSTDESC / gcr-catalogs

A Python module that provides a unified interface to access mock galaxy catalogs and more for the LSST DESC
https://github.com/LSSTDESC/gcr-catalogs
BSD 3-Clause "New" or "Revised" License
26 stars 20 forks source link

Changes for switching to treecorr convention for position_angle #608

Closed evevkovacs closed 1 year ago

evevkovacs commented 1 year ago

Legacy quantities have been renamed with _dc2. position_angle_true now uses morphology/position_angle and flips the sign to be consistent with the treecorr convention. ellipticity_1 and ellipticity_2 now use the supplied values of morphology/position_angle and convert to the treecorrr convention before computing the components.

evevkovacs commented 1 year ago

@yymao @heather999 The integration checks are failing. The first one is failing to load python 3.6! (Aren't we using 3.9?) And the remianing 2 checks are being cancelled. I need some help to resolve these issues. Thanks.

yymao commented 1 year ago

Thanks @evevkovacs. I'm fixing the action in #609. In the meantime can you update the schema file accordingly and include it in this PR?

evevkovacs commented 1 year ago

@yymao schema has been updated; checks have passed. Thanks!