search

LSSTDESC / gcr-catalogs

A Python module that provides a unified interface to access mock galaxy catalogs and more for the LSST DESC
https://github.com/LSSTDESC/gcr-catalogs
BSD 3-Clause "New" or "Revised" License
26 stars 20 forks source link

Changes and config files for skysim_v3.1 #622

Closed evevkovacs closed 1 year ago

evevkovacs commented 1 year ago

Here are the changes to cosmodc2.py and the necessary config files to make the new skysim_v3.1 available to the collaboration

yymao commented 1 year ago

@evevkovacs thanks for the PR and sorry for the delay. The config addition looks good. Can you update the readme accordingly?

Did you also add a new reader class SkySimGalaxyCatalog? Can you document the difference between SkySimGalaxyCatalog and the existing SkySim5000GalaxyCatalog?

Also, I noticed that the changes we made in #608 have been reverted back in this PR? I don't think that's intentional?

evevkovacs commented 1 year ago

Hmm, regarding the changes for #608, no that wasn't intentional, but I am a bit puzzled because I pulled from the latest gcr-catalogs before adding my changes. Let me look into this. I did add a new class. I will add the documentation for the differences. The new class is appropriate for the new generation of mocks. It seemed better to start a fresh class than try to massage the old one, since the underlying native quantities are quite different. Maybe I should change the name to avoid confusion? We could call it something like "DiffSkyGalaxyCatalog". What do you think?

yymao commented 1 year ago

Changing the class name sounds a good idea. I am not sure if DiffSky refers to some specific features of this catalog?

evevkovacs commented 1 year ago

@yymao Sorry for the long delay time in replying. I have added a couple of sentences of documentation. Please let me know if you would like more. I changed the new class name to DiffSky, because our new catalogs will most likely be called that. I also reinstated the position_angle changes. That was my oversight, caused by copying an older version of cosmodc2.py into the repository. If you are satisfied with the documentation, it is ready to merge. Thanks.

evevkovacs commented 1 year ago

@yymao I also just added the configuration files and updated README for the bug-fixed version of skysim5000_v1.2, which I uploaded for the collaboration meeting. Patricia and I had a miscommunication about the version number, so internally it is called v1.2 Hence, I needed to update the configuration files to make it consistent. I decided to add the changes to this branch because there were also additions to the README for v3.1 and I didn't want any of those to get lost.

evevkovacs commented 1 year ago

@yymao Thanks for the suggestions. I added very similar comments. Thanks for catching my (bad) typo of leaving 5000 in the catalog name. Everything should be addressed now.