search

LSSTDESC / gcr-catalogs

A Python module that provides a unified interface to access mock galaxy catalogs and more for the LSST DESC
https://github.com/LSSTDESC/gcr-catalogs
BSD 3-Clause "New" or "Revised" License
26 stars 20 forks source link

Diffsky v0.1 #625

Closed evevkovacs closed 11 months ago

evevkovacs commented 1 year ago

Two catalog configuration files for test catalogs for the roman-desc sims. The diffsky catalog is stored in the CS directory. It is not critical for this catalog to be generally available, but the special named version of the cosmoDC2 catalog should be pushed up to the main branch for more general use cosmodc2.py has also been modified for the diffsky catalog and this should also go in the main branch.

yymao commented 1 year ago

@evevkovacs thanks.

Two questions:

  1. Are we sure we don't want to copy the data to the general shared place? I'm slightly concerned that we are adding catalogs to the registry that don't live in the general shared place. Pining also @heather999 @JoanneBogart about this.
  2. Wouldn't the edits in the reader break backward compatibility?
JoanneBogart commented 1 year ago

The understanding has been that everything with a config file in the master branch is kept in the shared area. For one thing, this makes it easy to maintain the catalogs at another installation. Is there a reason not to copy the data there in this case?

evevkovacs commented 1 year ago

I will copy to the shared directory (if I can, or ping Heather) and update the configuration file. The diffsky catalogs are evolving rapidly, so this one will soon become obsolete, but that happened with cosmoDC2 also.

evevkovacs commented 1 year ago

Oops, I forgot that I had made those edits in the reader. I will have to edit those and make a version check or do something similar to ensure that I am not breaking the reader for the earlier catalogs. When perlmutter comes back up I will make those changes, test and push the new version.

evevkovacs commented 12 months ago

@yymao Here is the updated PR for the roman-rubin reader. I copied the latest catalog to the shared area, deleted the previous obsolete versions and updated the cosmodc2 reader so that it works on the new catalog and is backwards compatible.

yymao commented 11 months ago

@evevkovacs -- are you planning to remove the configs that have files not in the shared space?