search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Integrate Batoid for optical raytracing #10

Open cwwalter opened 8 years ago

cwwalter commented 8 years ago

This issue tracks the integration of @jmeyers314 's Batoid raytracing code with imsim.

Here we list important effects that we should be able to now implement.

cwwalter commented 7 years ago

Noting that @jmeyers314 now has started external python controlled code (batoid) that does this.

cwwalter commented 5 years ago

Added list of optical effects we hope to simulate with Batoid to the main issue post. For now these don't have their own issues, but let's track desired functionality here.

cwwalter commented 2 years ago

We are discussing various approaches to the spider and diffraction spikes. There are two main possible approaches: extra kicks in batoid and really calculating the diffractive PSF and using that same PSF contribution over the entire sensor (as is done in Roman). There was some discussion of the diffractive calculation previously in the GalSim repo that I am tagging here for reference. See the discussions with @rmandelb near the end of.

https://github.com/GalSim-developers/GalSim/issues/556

I will separately share some literature on the kick approach.

cwwalter commented 2 years ago

@jmeyers314 and @g-braeunlich , with this merge, should vignetting now be showing up emergently?

jmeyers314 commented 2 years ago

Vignetting of sources should show up I think. Vignetting of the background won't though.

cwwalter commented 2 years ago

Right.. That will be a good check.

cwwalter commented 1 year ago

Update: In addition to vignetting, we now have diffraction spikes including accounting for camera rotations relative to the spider (Both here with batoid and also parametrically for the the bright FFT case).

Ghosts and scattered light (which will be particularly important for simulating CBP calibration) will wait until the redesign of the parallelization strategy which will allow us to track light which spans multiple sensors via a 2nd pass.