LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Enable ImSim to run from Sky rather than/in addition to Instance Catalogs #222

Closed danielsf closed 4 years ago

danielsf commented 5 years ago

Given the resources (compute, storage, and personnel hours) devoted to InstanceCatalog generation during DC2, I would like to explore the possibility of allowing ImSim to run directly on the object catalogs (the equivalent of what cosmoDC2 was for DC2), without having to provide separate, externally generated InstanceCatalogs. My concerns with relying on InstanceCatalogs are as follows:

After off-line conversations with @jchiang87 and @cwwalter, I believe we are converging on a system in which ImSim still uses something like an InstanceCatalog, but in which ImSim also provides the tools to convert "object catalogs" (Jim's term for the cosmoDC2+stars+variability catalogs that were inputs to InstanceCatalogs in DC2) into InstanceCatalogs. Users who want to run ImSim on NERSC can just chain the InstanceCatalog generation and image generation steps together into one batch job. Users who want to run remotely can generate their InstanceCatalogs at NERSC (or wherever the object catalogs live) and export them to their remote systems where they will run ImSim. This scheme will make ImSim effectively independent of CatSim. This means we will need to address how to provide the variability models and astrometric models for the Earth's motion that are currently provided by CatSim.

I am opening this issue so that the broader community can comment on this strategy.

cwwalter commented 5 years ago

I've changed the title to 'Enable ImSim to run from Sky rather than/in addition to InstanceCatalogs' to be a little more explicit.

Here is also bit more background information on what we are thinking about (more summaries of the discussion with @jchiang87 and @danielsf ).

As part of the imSim redesign we are considering a new data product (which we are currently calling Sky Catalogs) that would be produced by the CS team from CosmoDCx + stars etc. These data file(s) will contain descriptions all of the objects we would want to simulate on the sky. It will be split up into sky chunks which only covers what we want to simulate. It will have all of the information for the objects that we want to simulate, critically including the proper motion and transient variability parameters.

This way, rather than having the objects on the same piece of sky repeated over and over again in the instance catalogs, they will be in one place and there will only be one entry for each object including anything we need to know for temporal variability. These sky catalog pieces can be distributed to remote sites. Using a pared down OpSim database file we can drive running imSim from that file.

imSim will have the option of either producing instance catalogs from the sky catalog (which can then be run) or it will be able to be run directly on the sky catalog itself. Produced instance catalogs can be used for checks of input used and also for running in lighter weight environments with resource limitations. Users will also be able to continue to create and run with instance catalogs for non DC scale simulation work where they have made the instance catalogs by hand or by some other program.

We imagine it likely that the sky catalogs will be produced and saved for DCx runs but that that instance catalogs won't be produced. This should reduce disk usage. One the sky catalogs are made the CS groups job will be done and imSim can run independently of it. As Scott mentions above we need consider how to properly treat the variability and astrometric models currently in CatSim now.

jchiang87 commented 5 years ago

@danielsf @cwwalter It's probably worth having a detailed document of the redesign we're proposing here so that there is something more coherent than a github issue to use as a reference later on. We can certainly continue to gather input in this issue (and even later, as comments on a google doc), but once things have crystallized, we should write up the final design.

cwwalter commented 5 years ago

OK sounds good.. I've been starting to try to set up some general infrastructure for the redesign planning and was planning on trying to use the wiki here in addition to issues so we can use that to host or have the information. (Note new "Redesign" label on this issue BTW).

cwwalter commented 4 years ago

See #71.