search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Changes in response to PR which was closed-early. #388

Closed cwwalter closed 1 year ago

cwwalter commented 1 year ago

Changes suggested by Mike. These changes were actually suggested in PR #378, but it was closed before his review was visible.

cwwalter commented 1 year ago

Note that this PR removes the imsim-user.yaml in config, and keeps the one in example. the install and usage instructions use the version in example. We will keep the config directory for non-user config templates etc only.

rmjarvis commented 1 year ago

Chris, I went ahead and made the edits I suggested. I think this is good to go now.

cwwalter commented 1 year ago

Thanks a lot Mike!

I want to make one more change before merging to make the examples file use the IMSIM_HOME env variable again that you removed.

I want to encourage people to run in a working directory (instead of the imSim directory itself) and make sure this can run from any directory successfully. The install test instructions have people doing this.

I will double check to make sure the new check you added in the CI still works.

rmjarvis commented 1 year ago

OK. I'll just register my objection to using IMSIM_HOME then. I don't like that style at all. But you do you.