search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Update the memory used by the atmospheric screen. #422

Closed cwwalter closed 1 year ago

cwwalter commented 1 year ago

Use the production instead of test value in the default config.

cwwalter commented 1 year ago

Did the last commit mean to say "ensure that the imsim versions.." are used?

jchiang87 commented 1 year ago

No, we want to use the GalSim versions for the regression test so that it's consistent with this.

cwwalter commented 1 year ago

OK, that is what I thought you were trying to do (so it was robust against these sort of changes) but I was confused because I saw this:

image

and it looked like you were switching from GalSim to the imsim bandpass.

jchiang87 commented 1 year ago

I think that was just a coding error (not sure where it came from). As far as I can tell, galsim.RubinBandpass doesn't exist, at least not in GalSim 2.4.11, but imsim.RubinBandpass does.

cwwalter commented 1 year ago

Ah.. OK. I see. I think that change was made when Mike added the new bandpass stuff. It's odd it made it through the tests.

jchiang87 commented 1 year ago

That script doesn't get run as part of the tests. It needs to be run by hand to generate the reference file. It would have failed much earlier when the skybrightness interface changed.