search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Add support for ComCam #433

Closed jmeyers314 closed 8 months ago

jmeyers314 commented 10 months ago

Adds support for ComCam.

Note, possibly only works on main branches of batoid and batoid_rubin at the moment. I had a bug in my ComCam optics yaml where both the camera and the camera+telescope were named ComCam. This collision meant when you tried to rotate the camera, you ended up rotating the entire telescope instead. Will be fixed in a point release soonish...

cwwalter commented 9 months ago

Jim, how does this instrument name choice match up with the desire to have a new instrument for the rehearsal with ITL constants?

Do you want to do this first and then make a new PR for that? Or do you want to have this as the default for when we get real constants and then make a new instrument just for the temporary usage?

jchiang87 commented 9 months ago

Jim, how does this instrument name choice match up with the desire to have a new instrument for the rehearsal with ITL constants?

Do you want to do this first and then make a new PR for that? Or do you want to have this as the default for when we get real constants and then make a new instrument just for the temporary usage?

We'd probably need to iterate with various people on a separate simulated ComCam model, so I'd be inclined to move forward with this, relying for now on the existing LSSTComCam model for testing, then make everything consistent with the final conventions, etc. after that process. I don't think using ComCam here along with the existing model should be a problem as long as we use test repos for these data until things have finalized.

cwwalter commented 9 months ago

Great thanks.