search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

missing conda installation requirement #437

Closed esheldon closed 8 months ago

esheldon commented 8 months ago

I followed conda instructions here: https://lsstdesc.org/imSim/install.html

It uses the requirements file etc/standalone_conda_requirements.txt

The code crashes due to missing yamlinclude, which means the requirements file needs pyyaml-include

cwwalter commented 8 months ago

I believe this is something that is new in skyCatalog and underdevelopment (not actually imSim). We should update the installation to instruct everyone to use a released skyCatalog version (and eventually when we understand all new requirements update that too including in cvmfs)

Erin, try, putting skyCatalog at

v1.6.0rc2

esheldon commented 8 months ago

Yes using that version works

cwwalter commented 8 months ago

Closing this issue.

esheldon commented 3 months ago

I think we might need to reopen this. There is a critical bug fix going in for skyCatalogs so we will want to go beyond v1.6.0rc2 and use the newest bug fix. Would you be open to adding pyyaml-include to the requirements now?

https://github.com/LSSTDESC/skyCatalogs/pull/102

jchiang87 commented 3 months ago

The most recent tag of skyCatalogs, v1.7.0rc4, removes the need for pyyaml-include. The current ci.yaml uses that version now.

esheldon commented 3 months ago

thanks