search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Unpin rubin-sim in conda reqs #454

Closed jmeyers314 closed 5 months ago

jchiang87 commented 5 months ago

I think we want to pin it at some version to avoid problems with the unit tests, especially the sky model tests. That's why it was pinned at 1.1.1.

rmjarvis commented 5 months ago

If possible, we should try to leave it unpinned and only pin it again if there are problems. People in the wild will continue to have whatever the latest is, so we will want to know when that is not compatible with how we are using it.

jmeyers314 commented 5 months ago

I don't understand. If I conda install ... packages one at a time, things work. If I conda install --file standalone_conda_requirements.txt" the same packages, then conda stdouts that it's done, but returns a non-zero exit status anyway so GHA thinks error. Gonna try with || true...

jmeyers314 commented 5 months ago

Seemed to get farther? But similar error when installing the test requirements? adding more || true...

jmeyers314 commented 5 months ago

Okay, that seems to have worked (rebasing now to clean up the history). Note I fixed a deprecation warning too in case anyone wants to review that.

cwwalter commented 5 months ago

The pickle to fits change of the fringing file is for the deprecation warning?

jmeyers314 commented 5 months ago

The pickle to fits change of the fringing file is for the deprecation warning?

Exactly. The pickle was holding a deprecated interpolation object, so I extracted the values-to-be-interpolated and put them in a fits instead.