search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Use a template dict for all the camera-specific info #459

Closed rmjarvis closed 4 months ago

rmjarvis commented 5 months ago

This is a proposal for IMO a neater way to handle the camera-specific information in the config file, rather than #456, which is currently an open PR. It reads in a config dict into a camera_info dictionary that other items can use. So the user only needs to update output.camera to get all the appropriate files for that camera. This seems to be what at least some users were expecting to happen when they changed that, so it feels like an API that would be intuitive.

Unfortunately, it is currently blocked by a GalSim bug, which has been fixed #1281, but will need to flow through to a bugfix release before this PR will work. But I think OK for people to take a look and comment on the design pattern already.

The PR is directed into u/jchiang/ComCam_configs to more easily see the differences with that one. If this is approved, we should merge this first, then PR #456.

jmeyers314 commented 5 months ago

Did you forget to commit the camera + '_info.yaml' files possibly?

rmjarvis commented 5 months ago

Yes. Thanks! (The peril of relying on git add -p.)

rmjarvis commented 4 months ago

OK. Fixed those items. Thanks.