search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Refactor stamp.py #468

Closed esheldon closed 6 months ago

esheldon commented 6 months ago

Pull out some useful functionality.

Useful stuff for calculating stamp sizes was put into stamp_utils.py

    get_stamp_size (was in LSST_SiliconBuilder.__init__)
        get_star_stamp_size
        get_gal_stamp_size
    get_good_phot_stamp_size (was LSST_SiliconBuilder._getGoodPhotImageSize)
    get_good_phot_stamp_size1 (was LSST_SiliconBuilder._getGoodPhotImageSize1)

Useful stuff for psfs was put into psf_utils.py

    make_double_gaussian (was LSST_SiliconBuilder.DoubleGaussian)
    make_kolmogorov_and_gaussian_psf was (LSST_SiliconBuilder.Kolmogorov_and_Gaussian_PSF)
    make_fft_psf (was LSST_SiliconBuilder.make_fft_psf)

Add a .flake8 to avoid some style complaints

esheldon commented 6 months ago

Who wants to take this one?

esheldon commented 6 months ago

The data download failed in the CI. I don't have permission to rerun the workflow, can someone please kick that off?

esheldon commented 6 months ago

Is this OK to merge now?

rmjarvis commented 6 months ago

It's fine by me, but I usually let Jim or Chris make the call.

jchiang87 commented 6 months ago

It's ok with me.

cwwalter commented 6 months ago

OK.