search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Use hardware bandpass for sky level #470

Closed jchiang87 closed 6 months ago

jchiang87 commented 6 months ago

This addresses #453

jchiang87 commented 6 months ago

Based on the description in SMTN-002, it looks like we should be using 703 cm, or perhaps more properly, computing the diameter from the values in that config.

jmeyers314 commented 6 months ago

Yep, I agree. I wonder what the best way to compute this programmatically is... We could put the inner/outer diameter into eval_variables, and then wire those up consistently to both PupilAnnulusSampler and SkyModel(here) maybe?

Using 703 cm as the default seems reasonable to me. (I suspect the median-over-FOV value is closer to this than to 642).

jchiang87 commented 6 months ago

an effective diameter of d = 2 * sqrt(4.18*2 - 2.552) = 703 cm, not 642 or 649 cm.

There's a typo here. Using d = 2 * sqrt(4.18**2 - 2.55**2), I get d = 662.4 cm.

jchiang87 commented 6 months ago

I'll also fix the pupil area in the skycat.py and instcat.py code in this PR.

jchiang87 commented 6 months ago

@jmeyers314 I've hooked up everything to use the eval_variables for the pupil annulus radii. Can you have another look?