search

LSSTDESC / imSim

GalSim based Rubin Observatory image simulation package
https://lsstdesc.org/imSim
BSD 3-Clause "New" or "Revised" License
36 stars 15 forks source link

Add TableRow #472

Closed jmeyers314 closed 3 months ago

jmeyers314 commented 3 months ago

Adds a custom InputType for the galsim config machinery to parse an astropy QTable. My current use case is to grab one row of the table for each AOS operations rehearsal 4 (OR4) exposure (example here), so this is similar to the OpsimData class. I wanted to be able to leverage units and structured array columns though, and lose some of the other peculiarities of OpSimData.

It's possible this would fit in better in GalSim than ImSim. Wherever it ends up, it should be part of a tag/release soonish I think for OR4 reproducibility.

jmeyers314 commented 3 months ago

This feels a little to specific a use case to put in GalSim proper. Probably imSim is a good home for it. But if you want, you could also submit it to galsim_extra if you think people outside of the imSim user community might want to use it.

Sure, ImSim is fine for now. Can always migrate later if that's useful.

jmeyers314 commented 3 months ago

Assuming this passes CI, I think it's ready for another look @rmjarvis .