search

LSSTDESC / lsstdesc-diffsky

Library for differentiable generation of synthetic skies for LSST DESC
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Improve diversity of bulge-to-total ratio #66

Closed aphearin closed 11 months ago

aphearin commented 11 months ago

This PR updates the model parameters used to decompose the SFH of a galaxy into disk/bulge/knot components. The upshot is that there is now a much greater diversity in B/T, and the model retains its predictions for a galaxy's disk SED to generally be redder than its knot SED, and for its bulge SED to be redder than its disk.

In this first figure, B/T is the ratio of the stellar mass of the bulge to the total stellar mass. In the old model there was not much diversity in morphology: nearly all z<1 galaxies were bulge-dominated with a bit of scatter about B/T=0.85. In the new model, there is a much larger range of B/T: for example, ~30% of galaxies are disk-dominated with B/T<0.5 (whereas previously this was ~0%). bt_vs_logsm_diffsky

The next few figures plot δ_color on the y-axis, computed as the difference in broadband color between one galaxy component and another. So when the y-axis is positive, the first component is redder than the second. The combination of the figures below gives assurance that the new model retains the same feature as the old: bulges are redder than disks are redder than knots, which is visible across a wide range in wavelength spanning at least u-y. delta_gr_vs_logsm_diffsky_bulge_vs_dd delta_gr_vs_logsm_diffsky_knot_vs_dd delta_iz_vs_logsm_diffsky_knot_vs_dd delta_ug_vs_logsm_diffsky_knot_vs_dd delta_zy_vs_logsm_diffsky_bulge_vs_dd

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (9ad9425) 56.19% compared to head (3c76591) 56.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== - Coverage 56.19% 56.16% -0.04% ========================================== Files 61 61 Lines 4251 4248 -3 ========================================== - Hits 2389 2386 -3 Misses 1862 1862 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [...tdesc\_diffsky/disk\_bulge\_modeling/mc\_disk\_bulge.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS9kaXNrX2J1bGdlX21vZGVsaW5nL21jX2Rpc2tfYnVsZ2UucHk=) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.