codecov[bot]
commented
8 months ago Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
9571879) 56.11% compared to head (0483f6b) 56.25%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== + Coverage 56.11% 56.25% +0.13% ========================================== Files 61 62 +1 Lines 4266 4279 +13 ========================================== + Hits 2394 2407 +13 Misses 1872 1872 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [lsstdesc\_diffsky/infer\_diffcode\_versions.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS9pbmZlcl9kaWZmY29kZV92ZXJzaW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@evevkovacs could you finish this PR by modifying
write_mock_to_diskin such a way that uses the newinfer_software_versionsfunction? This way the different versions of the Diff+ software are inferred dynamically at runtime. So writing these versions to disk as metadata will be a bit more robust than having to make sure to manually record the correct commit hash.Note that in order for to this to pass, you will need to have the most recent release of Diffstar installed, v0.2.2, which was only released 2 days ago.