search

LSSTDESC / lsstdesc-diffsky

Library for differentiable generation of synthetic skies for LSST DESC
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Roman rubin 2023 #72

Closed evevkovacs closed 8 months ago

evevkovacs commented 8 months ago

Here is the PR for the changes to run the latest version for roman_rubin_2023_v0.1.0 and v0.1.1 These are minor changes to run scripts and some minor changes to write_mock_to_disk.py for saving software versions to metadata, using sfr_precentile in the black hole model and ingesting alternate parameter files.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (27c5738) 56.25% compared to head (3cb96b0) 56.19%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ========================================== - Coverage 56.25% 56.19% -0.06% ========================================== Files 62 62 Lines 4279 4285 +6 ========================================== + Hits 2407 2408 +1 - Misses 1872 1877 +5 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [...synthetic\_subhalos/synthetic\_cluster\_satellites.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS9zeW50aGV0aWNfc3ViaGFsb3Mvc3ludGhldGljX2NsdXN0ZXJfc2F0ZWxsaXRlcy5weQ==) | `7.57% <ø> (ø)` | | | [lsstdesc\_diffsky/write\_mock\_to\_disk.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS93cml0ZV9tb2NrX3RvX2Rpc2sucHk=) | `11.36% <9.09%> (+0.07%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/72/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aphearin commented 8 months ago

This PR is superseded by #76