search

LSSTDESC / lsstdesc-diffsky

Library for differentiable generation of synthetic skies for LSST DESC
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Roman rubin final #85

Closed evevkovacs closed 8 months ago

evevkovacs commented 8 months ago

Updates for latest throughputs for lsst and roman and config file changes for v1.0.1

codecov[bot] commented 8 months ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (28d8d84) 60.62% compared to head (fc2c055) 60.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #85 +/- ## ========================================== - Coverage 60.62% 60.40% -0.22% ========================================== Files 95 95 Lines 6740 6766 +26 ========================================== + Hits 4086 4087 +1 - Misses 2654 2679 +25 ``` | [Files](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [lsstdesc\_diffsky/write\_mock\_to\_disk.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS93cml0ZV9tb2NrX3RvX2Rpc2sucHk=) | `11.53% <0.00%> (ø)` | | | [lsstdesc\_diffsky/photometry/load\_filter\_data.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS9waG90b21ldHJ5L2xvYWRfZmlsdGVyX2RhdGEucHk=) | `16.94% <12.50%> (-0.36%)` | :arrow_down: | | [lsstdesc\_diffsky/validation/get\_catalog\_data.py](https://app.codecov.io/gh/LSSTDESC/lsstdesc-diffsky/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-bHNzdGRlc2NfZGlmZnNreS92YWxpZGF0aW9uL2dldF9jYXRhbG9nX2RhdGEucHk=) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aphearin commented 8 months ago

This PR introduces a new dependency on galsim, which is used to retrieve roman filters. A new test of this new feature should be included before this PR is merged into main.