Open johannct opened 6 years ago
I need a little more context @johannct.
there is a pipeline tool, that needs its config file, like any other pipeline tool..... but it is missing.
Just created a new branch, https://github.com/LSSTDESC/obs_lsstSim/tree/u/heather999/issue_14, where I add in the makeCoaddTempExp.py file from HSC. Nominally I would hope that would work, but we need to confirm the contents with @SimonKrughoff and Bob Armstrong (who I don't see here on github yet - we'll try to fix that today).
I guess this line needs a modif :
config.load(os.path.join(getPackageDir("obs_subaru"), "config", "coaddBase.py"))
ah.. helps to read the config file! :) I've added in HSC's coaddBase.py and updated makeCoaddTempExmp.py
I must say I'm not really up to speed on some of the newer features. Specifically, doAttachTransmissionCurve
and doApplySkyCorr
require us to have transmission curves and the sky correction. Are we doing those steps?
We currently do not have the calibration files to perform sky correction.
In coaddBase.py
config.doApplyUberCal
should be set to False as we don't run jointcal
Finally done, is this enough to allow us to merge this issue? I'll open a PR and assign some reviewers
we should close this issue, as we moved away from obs_lsstSim anyway for DC2.
It may be entirely empty if we do not run jointcal? But it needs to be there