search

LSSTDESC / obs_lsstSim

Configuration and tasks for the simulated LSST camera (lsstSim) for the LSST Data Management Stack
2 stars 0 forks source link

makeCoaddTempExConfig.py missing #14

Open johannct opened 6 years ago

johannct commented 6 years ago

It may be entirely empty if we do not run jointcal? But it needs to be there

heather999 commented 6 years ago

I need a little more context @johannct.

johannct commented 6 years ago

there is a pipeline tool, that needs its config file, like any other pipeline tool..... but it is missing.

heather999 commented 6 years ago

Just created a new branch, https://github.com/LSSTDESC/obs_lsstSim/tree/u/heather999/issue_14, where I add in the makeCoaddTempExp.py file from HSC. Nominally I would hope that would work, but we need to confirm the contents with @SimonKrughoff and Bob Armstrong (who I don't see here on github yet - we'll try to fix that today).

johannct commented 6 years ago

I guess this line needs a modif : config.load(os.path.join(getPackageDir("obs_subaru"), "config", "coaddBase.py"))

heather999 commented 6 years ago

ah.. helps to read the config file! :) I've added in HSC's coaddBase.py and updated makeCoaddTempExmp.py

SimonKrughoff commented 6 years ago

I must say I'm not really up to speed on some of the newer features. Specifically, doAttachTransmissionCurve and doApplySkyCorr require us to have transmission curves and the sky correction. Are we doing those steps?

johannct commented 6 years ago

We currently do not have the calibration files to perform sky correction.

boutigny commented 6 years ago

In coaddBase.py config.doApplyUberCal should be set to False as we don't run jointcal

heather999 commented 6 years ago

Finally done, is this enough to allow us to merge this issue? I'll open a PR and assign some reviewers

johannct commented 6 years ago

we should close this issue, as we moved away from obs_lsstSim anyway for DC2.