Open heather999 opened 6 years ago
I think that we should set config.doAttachTransmissionCurve = False
. Regarding skyCorrection, I don't know if it makes sense to run it. I will ask HSC people.
Informations on skyCorrection
is available at: https://community.lsst.org/t/hsc-defaults-now-require-sky-correction/2631
At first look, I would say that we need to run it
Thank you @boutigny. I set doAttachTransmissionCurve to False. Concerning skyCorrection, I assume we should pull in HSC's skyConfig.py? The contents are minimal:
import os.path
from lsst.utils import getPackageDir
config.bgModel.load(os.path.join(getPackageDir("obs_subaru"), "config", "hsc", "focalPlaneBack
ground.py"))
But I'm not sure their focalPlaneBackground.py
is appropriate for our use. Its contents are:
more focalPlaneBackground.py
# Configuration for background model of the entire focal-plane
config.xSize = 1024
config.ySize = 1024
I think Bob Armstrong may be looking at skyCorrection.py too, I don't have a way to ping him yet on these Github repos, but perhaps something to discuss at the DM-DC2 meeting.
The HSC focalPlaneBackground.py
is certainly not suitable for obs_lsstSim
. We need to figure out how to build one.
Now that Bob Armstrong is in the Github organization, I've added him to this PR.
@jchiang87 is this something to add to your growing list of questions for DM or perhaps Hsin-Fang Chiang? What Slack channel(s) do we use to communicate with her?
I don't actually have a growing list per se. For stuff like this, I would post on community.lsst.org, since Leanne has asked that we make use of that forum where possible.
I'm not sure I understand why focalPlaneBackground.py
wouldn't work for obs_lsstSim
. We may want to tweak the parameters, but I don't see why the algorithm shouldn't work.
adding HSC's makeCoaddTempExp config file