search

LSSTDESC / rail

Top level "umbrella" package for RAIL
MIT License
8 stars 4 forks source link

Outdated estimators explained in goldenspike #20

Closed OliviaLynn closed 10 months ago

OliviaLynn commented 1 year ago

The goldenspike.ipynb markdown cell called "Estimate photo-z posteriors" contains written descriptions of randomPZ, trainZ, and BPZ_lite, while the notebook's code has since been updated to use BPZ_lite, KNearNeighPDF, and FZBoost.

These explanations should be updated to match.

There may be other discrepancies throughout the notebook--trying to wrap something up so I haven't checked.

sschmidt23 commented 1 year ago

I can try to clean this up, it's likely that I'm the one that forgot to update the notebook. I'll assign myself now and update the notebook tomorrow.

sschmidt23 commented 1 year ago

Actually, I'll wait until LSSTDESC/RAIL#372 is merged to avoid conflicts and make sure that I'm writing updates that are current with any changes there.

aimalz commented 10 months ago

Sorry for missing this while I was out of commission last week, and thanks for taking care of it! I was working on #20 in another branch but let it succumb to scope creep so this is just to let people know that I'll continue working on that without reopening the original issue.