search

LSSTDESC / rail

Top level "umbrella" package for RAIL
MIT License
8 stars 4 forks source link

Data script #43

Closed OliviaLynn closed 1 year ago

OliviaLynn commented 1 year ago

Change Description

Solution Description

A script to check for existence of data files and curl what is missing.

Required for rail_attic's #372 (fixing goldenspike pipeline); addresses rail_attic #356 (moving data) and rail #26 (moving demo files).

Notebooks that require data can curl directly within a cell, but additional care is needed in cases such as running a pipeline from command line.

This solution is proposed as a centralized and readable method to handle external data without requiring users to copy and paste a list of curl commands into their command line.

Code Quality

Project-Specific Pull Request Checklists

New Feature Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b7ce942) 100.00% compared to head (f782621) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eacharles commented 1 year ago

Maybe make this a part of the rail command line interface?  On Jun 27, 2023, at 6:24 PM, Olivia R. Lynn @.***> wrote: Change Description

My PR includes a link to the issue that I am addressing

Solution Description

A script to check for existence of data files and curl what is missing. Required for rail_attic's #372 (fixing goldenspike pipeline); addresses rail_attic #356 (moving data) and rail #26 (moving demo files). Notebooks that require data can curl directly within a cell, but additional care is needed in cases such as running a pipeline from command line. This solution is proposed as a centralized and readable method to handle external data without requiring users to copy and paste a list of curl commands into their command line. Code Quality

I have read the Contribution Guide My code follows the code style of this project My code builds (or compiles) cleanly without any errors or warnings My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists New Feature Checklist

I have added or updated the docstrings associated with my feature using the NumPy docstring format (Will complete following, pending discussion resolution): I have updated the tutorial to highlight my new feature (if appropriate) I have added unit/End-to-End (E2E) test cases to cover my new feature

You can view, comment on, or merge this pull request online at:   https://github.com/LSSTDESC/rail/pull/43

Commit Summary

f782621 Initial script (with one file)

File Changes (1 file)

A
get_data.py
(35)

Patch Links:

https://github.com/LSSTDESC/rail/pull/43.patch https://github.com/LSSTDESC/rail/pull/43.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

eacharles commented 1 year ago

Maybe make this part of the rail command line interface?On Jun 27, 2023, at 7:43 PM, Drew Oldag @.***> wrote: @drewoldag approved this pull request.

This looks really useful!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

OliviaLynn commented 1 year ago

Thanks for the suggestion @eacharles, translated to a cli script in rail_base (PR #20)