LSSTDESC / rail

Top level "umbrella" package for RAIL
MIT License
8 stars 4 forks source link

Updating smoke test to emit status to Slack app. #76

Closed drewoldag closed 10 months ago

drewoldag commented 10 months ago

Change Description

This change will emit a json package to a webhook configured in the LSSTC slack app, "RAIL CI Reporter".

The slack app will send a message to the #desc-pz-rail channel displaying the status of the smoke test. This was meant to be fairly quick and dirty, so if it gets too noisy (especially if we add this to other repositories) we can add some conditional logic in there that will only emit on failure for instance.

Additionally, it might be nice to have some kind of an "acknowledge" button in the event of a failure message that would signal to the other members of the channel that someone has at least noticed that there's a build problem.

The current output looks something like this:

lsstdesc/rail

Smoke test result: success ✔️ < link to the build page for the workflow that produced this result >

eacharles commented 10 months ago

Thanks for doing this. My vote would be to only send the message on failure and not bother with the acknowledgement.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (6ea61e7) 100.00% compared to head (145a5b0) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drewoldag commented 10 months ago

My only counter argument to the "only send on failure" is that if for some reason the pipeline stops working, then it would be harder to discover. And we would be in the same boat we're in now.

Nevermind, you were right, with the matrix operation going on here, it makes more sense to just emit failures instead of a huge number of successes for this job.

We can always reconsider if needed.