LSSTDESC / rail

Top level "umbrella" package for RAIL
MIT License
8 stars 4 forks source link

Draft: Gather fsps, bpz, and cmnn demos #78

Closed OliviaLynn closed 10 months ago

OliviaLynn commented 10 months ago

Change Description

Gathering external demos as described in https://github.com/LSSTDESC/rail/issues/48

See running notes in my comment there.

Code Quality

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c15b902) 100.00% compared to head (99eba5c) 100.00%. Report is 30 commits behind head on main.

:exclamation: Current head 99eba5c differs from pull request most recent head dd3c81c. Consider uploading reports for the commit dd3c81c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sschmidt23 commented 10 months ago

For BPZ, having the data at NERSC and just adding a curl command in the notebook seems good to me; however, BPZ_lite does expect the files to be in the SED directory, so we would still need to untar and copy them to the proper directory in the notebook. This is already done in the commented-out commands in the current demo notebook, but I'm mentioning as having them commented out as I currently would cause auto-running of the notebook to fail if rendered as part of automated testing. So, those lines should probably be uncommented when the BPZ_lite_with_custom_SEDs.ipynb notebook is moved.