search

LSSTDESC / rail

Top level "umbrella" package for RAIL
MIT License
8 stars 4 forks source link

61 adding jupyter notebook for plotting and visualisation of dc2 and skysim simulations #82

Closed torluca closed 10 months ago

torluca commented 10 months ago

This branch is meant to satisfy the requirement in my in-kind contribution of creating a plotting interface in RAIL with skysim and cosmoDC2.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (95c5b27) 100.00% compared to head (774d1eb) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

torluca commented 10 months ago

To run the notebook, the user needs to have dsps, diffstar and jax installed. Maybe it would make more sense to move it into rail_dsps, what do you think?

aimalz commented 10 months ago

To run the notebook, the user needs to have dsps, diffstar and jax installed. Maybe it would make more sense to move it into rail_dsps, what do you think?

@torluca It seems that we've standardized on putting all notebooks in the central rail repo rather than the repos corresponding to the packages each notebook requires. It's nice to have them in one place because users can clone just the one repo to get all the demos, rather than cloning lots of them. However, the fact that vanilla rail's default installation includes only rail_base definitely detracts from the utility of having the notebooks centralized here. Please do chime in on the discussion in #29 if you have any thoughts on this setup.

eacharles commented 10 months ago

The vanilla installation is intended for something different.  (A truly vanilla installation where you add only the things you need by hand.).  The dev installation is intended for running notebooks.   On Oct 17, 2023, at 10:16 AM, Alex Malz @.***> wrote:

To run the notebook, the user needs to have dsps, diffstar and jax installed. Maybe it would make more sense to move it into rail_dsps, what do you think?

@torluca It seems that we've standardized on putting all notebooks in the central rail repo rather than the repos corresponding to the packages each notebook requires. It's nice to have them in one place because users can clone just the one repo to get all the demos, rather than cloning lots of them. However, the fact that vanilla rail's default installation includes only rail_base definitely detracts from the utility of having the notebooks centralized here. Please do chime in on the discussion in #29 if you have any thoughts on this setup.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>