Closed eacharles closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
e4f0d85
) 100.00% compared to head (53bac20
) 100.00%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hm, this does make me realize some weird splits in the installation requirements, between m1s, macs, and zsh:
M1: We initially added the tabs with the idea of simplifying the "extra M1 requirements" that used to exist, but it's really just conda installing healpy at this point.
Mac: Looking this over, I was a little wrong to group the delight extra instructions under M1 (when it applies to all Macs, it seems).
zsh: You bring up a good point that these commands are implicitly targeting zsh, without really acknowledging that. Maybe we should make a note somewhere?
However, I'm a little worried that making zsh the focus of the tab would detract from the conda/healpy requirement further down. Also, making General/Mac/Apple-Silicon tabs seems excessive. Maybe it would be best to just take the delight instructions out of the tab? I'd be happy to talk this over tomorrow.
Change Description
Solution Description
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist