LSSTDESC / rail_astro_tools

Rail utility stages that depend on astronomy package such as healpy, astropy etc...
MIT License
0 stars 0 forks source link

Added error model using PhotErr. #10

Closed jfcrenshaw closed 1 year ago

jfcrenshaw commented 1 year ago

Change Description

This PR addresses this ticket, by moving the LSSTErrorModel from rail_base to this repo, and removing the explicit error model implementation by just wrapping the error model in PhotErr.

Once this PR is merged, we need to merge two other PRs:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.69% :tada:

Comparison is base (11ee329) 79.06% compared to head (a14ae2f) 79.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ========================================== + Coverage 79.06% 79.75% +0.69% ========================================== Files 5 6 +1 Lines 640 662 +22 ========================================== + Hits 506 528 +22 Misses 134 134 ``` | [Files Changed](https://app.codecov.io/gh/LSSTDESC/rail_astro_tools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [src/rail/creation/degradation/lsst\_error\_model.py](https://app.codecov.io/gh/LSSTDESC/rail_astro_tools/pull/10?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvY3JlYXRpb24vZGVncmFkYXRpb24vbHNzdF9lcnJvcl9tb2RlbC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.