search

LSSTDESC / rail_astro_tools

Rail utility stages that depend on astronomy package such as healpy, astropy etc...
MIT License
0 stars 0 forks source link

Update for ceci version 2 #45

Closed joezuntz closed 1 month ago

joezuntz commented 2 months ago

This PR updates the constructors of all stage subclasses to work with ceci version 2, in which aliases are specified in the constructor. A similar PR has been opened for each RAIL repo.

The main change is to the the constructors to accept any keywords with **kwargs and pass them to the parent class.

I have also removed any constructors which did not do anything except call the parent class constructor. Since this happens automatically if you omit the constructor, these were redundant.

Finally, in constructors I have changed I have removed hard-coded parent classes in favour of the python3 recommended super() function. If the parent class are changed in the future the constructor will still work.

BStoelzner commented 2 months ago

I fixed the np.product error in https://github.com/LSSTDESC/rail_astro_tools/pull/46, but there is an incompatibility between numpy and pandas versions, see https://github.com/numpy/numpy/issues/26710

joezuntz commented 1 month ago

Since this is orthogonal to the numpy issue can it be merged?