Closed yanzastro closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
3e87207
) compared to base (57b84f2
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Oh, and one more thing, even though I approved this: do we actually need to include output_SOMoclu_model.pkl
? RAIL is getting rather bloated, if the file is not needed then we should delete it from the repo before you merge this PR.
Hi @sschmidt23 and sorry for the late reply. I forgot to check my RAIL email folder again. Here I'll reply to all your comments:
I just noticed that a couple changes that I made to get the notebook running and some linting fixes did not actually get pushed to the repo for some reason, I'll test re-running the notebook and apply the needed changes now.
I added hierarchical clustering function into the somoclu summarizer and add some example cells in the corresponding example notebook.