search

LSSTDESC / rail_attic

Redshift Assessment Infrastructure Layers
MIT License
14 stars 9 forks source link

Issue/304/cleanup #306

Closed sschmidt23 closed 1 year ago

sschmidt23 commented 1 year ago

For a minor clean up, this PR just deletes two old pickled model files and a duplicate copy of the HDFN prior. One of the tests did use the demo_snn.pkl file that was deleted, but it's only a check on opening a pickled model file, so I changed that to instead read in the remaining copy of CWW_HDFN_prior.pkl.

sschmidt23 commented 1 year ago

And we should create a new tagged version of RAIL once this is merged to resolve the sklearn deprecation that is now being enforced by PyPI

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0228aa7) 100.00% compared to head (38172ed) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 38 38 Lines 2507 2507 ========================================= Hits 2507 2507 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.