LSSTDESC / rail_attic

Redshift Assessment Infrastructure Layers
MIT License
14 stars 9 forks source link

Dsps: codecov reminder and move files #341

Closed OliviaLynn closed 1 year ago

OliviaLynn commented 1 year ago

A personal reminder to go back and address the uncovered code in dsps_sed_modeler.py and dsps_photometry_creator.py, as my directory renaming PR indirectly reduced the codecoverage for these files (pragma-no-covers temporarily added in commits 438319a and d0d5730)

Additionally, Alex has identified that these (as well as the third item in the galaxy_modelling dir, galaxy_population_components.py) as being better off in the engines directory, so I will move them while investigating their code coverage.

Edit [Apr 26]: the codecov report for rail's current main branch now shows 100%, even with the removal of these temporary pragma: no cover's.

Including the codecov report for PR #325 with only 98.72% coverage for archival purposes (do we have race conditions or some other kind of non-determinism in the dsps tests?), but unless this occurs again, it will be considered low priority.