LSSTDESC / rail_attic

Redshift Assessment Infrastructure Layers
MIT License
14 stars 9 forks source link

Define a new MPI communicator when data set is small #351

Closed joselotl closed 1 year ago

joselotl commented 1 year ago

When data set is small, define a new communicator that only has the needed processes to compute the current model. This is written in input_iterator so that it works with any algorithm using iterators.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (64b35ec) 100.00% compared to head (9749e69) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 38 38 Lines 2581 2587 +6 ========================================= + Hits 2581 2587 +6 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/LSSTDESC/RAIL/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC) | Coverage Δ | | |---|---|---| | [src/rail/core/stage.py](https://app.codecov.io/gh/LSSTDESC/RAIL/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC#diff-c3JjL3JhaWwvY29yZS9zdGFnZS5weQ==) | `100.00% <100.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/LSSTDESC/RAIL/pull/351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LSSTDESC)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

joselotl commented 1 year ago

@eacharles As we discused in the tag-ups, I didn't include the unit tests for this. It would need to use mpi in the github actions.

joselotl commented 1 year ago

@eacharles @sschmidt23 This PR is ready to merge, it only needs an approving review